refactor: remove finch conversion, support zstd and lzma in wasm #3521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizirber
force-pushed
the
lirber/zstd_wasm
branch
from
d173ebf to
514ac87
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #3521 +/- ##
==========================================
- Coverage 88.02% 87.98% -0.05%
==========================================
Files 137 136 -1
Lines 22312 22230 -82
Branches 2225 2225
==========================================
- Hits 19640 19558 -82
Misses 2359 2359
Partials 313 313
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
luizirber
force-pushed
the
lirber/zstd_wasm
branch
from
514ac87 to
7ffd065
Compare
bluegenes
approved these changes
Feb 4, 2025
yeah, removing a feature is a breaking change... we can also keep finch and not enable lzma in niffler, which would be fine too (I don't see much genomic data in xz format?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address sourmash-bio/branchwater#41
Allow zstd and lzma in wasm.
Removed finch conversion because it has conflicts with lzma version, but also... I don't think it was ever used? People can stick to
0.18.0and we can bring it back if needed.