Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] update various descriptions to talk about k-mers, not just DNA #2137

Merged
merged 4 commits into from
Jul 23, 2022

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Jul 23, 2022

This PR adjusts sourmash doc descriptions to emphasize "k-mers" and "biological sequences", not just "DNA sequences".

This PR also edits a number of dib-lab/sourmash references to sourmash-bio/sourmash references.

fixes #2115

@codecov
Copy link

codecov bot commented Jul 23, 2022

Codecov Report

Merging #2137 (7c2f1f0) into latest (8beaaca) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 7c2f1f0 differs from pull request most recent head 51526e7. Consider uploading reports for the commit 51526e7 to get more accurate results

@@           Coverage Diff           @@
##           latest    #2137   +/-   ##
=======================================
  Coverage   84.31%   84.31%           
=======================================
  Files         130      130           
  Lines       15293    15293           
  Branches     2167     2167           
=======================================
  Hits        12895    12895           
  Misses       2095     2095           
  Partials      303      303           
Flag Coverage Δ
python 91.70% <100.00%> (ø)
rust 65.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/__init__.py 100.00% <ø> (ø)
src/sourmash/cli/__init__.py 95.74% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@mr-eyes mr-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ctb ctb merged commit 5cfde22 into latest Jul 23, 2022
@ctb ctb deleted the remove/DNA_doc branch July 23, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove "DNA" from various sourmash descriptors
2 participants