Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] CI: Update cibuildwheel usage #1759

Merged
merged 2 commits into from
Oct 25, 2021
Merged

[MRG] CI: Update cibuildwheel usage #1759

merged 2 commits into from
Oct 25, 2021

Conversation

luizirber
Copy link
Member

We are running a fairly old version of cibuildwheel (1.8.0, newest is 2.2.0), so let's try to benefit from all the good features in the new one (like musllinux wheel support)

@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #1759 (106bc99) into latest (d91911b) will increase coverage by 7.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1759      +/-   ##
==========================================
+ Coverage   82.84%   90.10%   +7.26%     
==========================================
  Files         114       87      -27     
  Lines       12211     8401    -3810     
  Branches     1555     1555              
==========================================
- Hits        10116     7570    -2546     
+ Misses       1837      573    -1264     
  Partials      258      258              
Flag Coverage Δ
python 90.10% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/wasm.rs
src/core/src/sketch/hyperloglog/mod.rs
src/core/src/sketch/nodegraph.rs
src/core/src/from.rs
src/core/src/index/sbt/mhbt.rs
src/core/src/sketch/minhash.rs
src/core/src/ffi/cmd/compute.rs
src/core/src/index/bigsi.rs
src/core/src/index/storage.rs
src/core/src/ffi/minhash.rs
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d91911b...106bc99. Read the comment docs.

@luizirber luizirber changed the title [WIP] Update cibuildwheel usage [MRG] Update cibuildwheel usage Oct 25, 2021
@luizirber luizirber changed the title [MRG] Update cibuildwheel usage [MRG] CI: Update cibuildwheel usage Oct 25, 2021
@luizirber
Copy link
Member Author

Ready for review and merge @sourmash-bio/devs

@mr-eyes
Copy link
Member

mr-eyes commented Oct 25, 2021

Hi, @luizirber I have a question. How supporting musllinux in building wheels will be beneficial here in sourmash? In other words, how that will affect the sourmash building/running?

Copy link
Member

@mr-eyes mr-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@luizirber
Copy link
Member Author

Hi, @luizirber I have a question. How supporting musllinux in building wheels will be beneficial here in sourmash? In other words, how that will affect the sourmash building/running?

Currently it is not possible to run sourmash (easily) in distros using musl as the C standard library. manylinux wheels are intended for GLIBC, and trying to pip install sourmash in Alpine (which uses musl) will trigger compilation from source. musllinux is a new wheel format that accounts for musl systems, and so now users in Alpine can run the same as users in Ubuntu or Fedora.

It doesn't change anything for any non-musl dev environments, but it does increase the build time because there are two extra wheels being compiled, for x86_64 and aarch64. The latter takes a LONG time, but it is not a required check for merging PRs (only x86_64 wheels are required, in either Linux or MacOS).

@luizirber luizirber merged commit 5accf22 into latest Oct 25, 2021
@luizirber luizirber deleted the cibuildwheel_2.2.0 branch October 25, 2021 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants