-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] CI: Update cibuildwheel usage #1759
Conversation
d5acb5a
to
4d1cc0f
Compare
Codecov Report
@@ Coverage Diff @@
## latest #1759 +/- ##
==========================================
+ Coverage 82.84% 90.10% +7.26%
==========================================
Files 114 87 -27
Lines 12211 8401 -3810
Branches 1555 1555
==========================================
- Hits 10116 7570 -2546
+ Misses 1837 573 -1264
Partials 258 258
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
88b2be8
to
f38d41e
Compare
f38d41e
to
106bc99
Compare
Ready for review and merge @sourmash-bio/devs |
Hi, @luizirber I have a question. How supporting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :)
Currently it is not possible to run sourmash (easily) in distros using musl as the C standard library. It doesn't change anything for any non-musl dev environments, but it does increase the build time because there are two extra wheels being compiled, for |
We are running a fairly old version of cibuildwheel (
1.8.0
, newest is2.2.0
), so let's try to benefit from all the good features in the new one (likemusllinux
wheel support)