Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add zipfile collection support #1429

Closed
wants to merge 87 commits into from
Closed

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Apr 1, 2021

Note: Merge into #1420

This merges the zipfile collection stuff in #1349 with the much-simplified database loading in #1406 and signature selection in #1420.

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Please note your ORCID in the comments. If you don't have one, you can register for one here.

ctb added 30 commits February 25, 2021 07:09
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

❗ No coverage uploaded for pull request base (refactor/siglist_loading@6d8663e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                     Coverage Diff                     @@
##             refactor/siglist_loading    #1429   +/-   ##
===========================================================
  Coverage                            ?   67.37%           
===========================================================
  Files                               ?       27           
  Lines                               ?     3614           
  Branches                            ?        0           
===========================================================
  Hits                                ?     2435           
  Misses                              ?     1179           
  Partials                            ?        0           
Flag Coverage Δ
rust 67.37% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d8663e...be502ab. Read the comment docs.

Base automatically changed from refactor/siglist_loading to refactor/db_load_multiindex April 1, 2021 22:23
Base automatically changed from refactor/db_load_multiindex to latest April 2, 2021 14:08
@ctb
Copy link
Contributor Author

ctb commented Apr 2, 2021

closing now that #1420 and #1406 are merged => #1349.

@ctb ctb closed this Apr 2, 2021
@ctb ctb deleted the add/zipfile_index_merge branch August 20, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant