Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Reduce wasm surface by removing index #1399

Closed
wants to merge 2 commits into from

Conversation

luizirber
Copy link
Member

For greyhound.sourmash.bio and similar browser-side demos I've been using a subset of sourmash that is compilable to webassembly. To make sure that new features and dependencies are added that break what webassembly supports I added a CI check that tries to build a JS package using wasm-pack.

But... that limits quite a bit what we can add to sourmash. We can't have C/C++ deps, for example. It also holds back some parallel stuff because rayon doesn't work well on wasm without many tweaks.

So, this PR removes some submodules from wasm (using configuration flags) so we can explore more before commiting to maintaining it in the long run, namely:

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@luizirber
Copy link
Member Author

#1643 is a better solution.

@luizirber luizirber closed this Dec 19, 2021
@luizirber luizirber deleted the reduce_wasm_surface branch March 27, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant