[WIP] Reduce wasm surface by removing index #1399
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For greyhound.sourmash.bio and similar browser-side demos I've been using a subset of sourmash that is compilable to webassembly. To make sure that new features and dependencies are added that break what webassembly supports I added a CI check that tries to build a JS package using
wasm-pack
.But... that limits quite a bit what we can add to sourmash. We can't have C/C++ deps, for example. It also holds back some parallel stuff because rayon doesn't work well on wasm without many tweaks.
So, this PR removes some submodules from wasm (using configuration flags) so we can explore more before commiting to maintaining it in the long run, namely:
Checklist
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?