Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 Support #26

Merged
merged 2 commits into from
Jan 6, 2025
Merged

PHP 8.4 Support #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b68922
build: support php8.4
iBotPeaches Nov 30, 2024
3df3c6a
chore: pint v1.19.0
iBotPeaches Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
fail-fast: true
matrix:
php: [8.2, 8.3]
php: [8.2, 8.3, 8.4]
laravel: [11.0]
name: PHP ${{ matrix.php }} - Laravel ${{ matrix.laravel }}
steps:
Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@
}
],
"require": {
"php": "^8.2",
"php": "^8.2||^8.3||^8.4",
"ext-simplexml": "*",
"ext-soap": "*",
"illuminate/support": "^11"
},
"require-dev": {
"orchestra/testbench": "^9.2",
"phpunit/phpunit": "^11.2",
"laravel/pint": "^1.17"
"laravel/pint": "^1.19"
},
"autoload": {
"psr-4": {
Expand Down
12 changes: 6 additions & 6 deletions src/SoapyCurtain.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class SoapyCurtain

protected array $typeMap = [];

//region getters
// region getters

public function getWsdl(): ?string
{
Expand Down Expand Up @@ -96,9 +96,9 @@ public function getTypemap(): ?array
return $this->typeMap;
}

//endregion
// endregion

//region setters
// region setters

public function setWsdl(string $wsdl): self
{
Expand Down Expand Up @@ -194,9 +194,9 @@ public function addTypeMap(string $namespace, string $item, \Closure $fromXml):
return $this;
}

//endregion
// endregion

//region functions
// region functions

public function isReady(): bool
{
Expand All @@ -207,5 +207,5 @@ public function isReady(): bool
return ! empty($this->getWsdl());
}

//endregion
// endregion
}
2 changes: 1 addition & 1 deletion tests/BaseTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class BaseTestCase extends TestCase
{
protected $baseWsdl;

public function setUp(): void
protected function setUp(): void
{
parent::setUp();
$this->baseWsdl = __DIR__.'/example.wsdl';
Expand Down
4 changes: 2 additions & 2 deletions tests/Unit/CustomClassTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

class CustomClassTest extends BaseTestCase
{
public function testCreatingClientWithNoCustomOverload()
public function test_creating_client_with_no_custom_overload()
{
$client = SoapyFacade::create(function (SoapyCurtain $curtain) {
return $curtain
Expand All @@ -24,7 +24,7 @@ public function testCreatingClientWithNoCustomOverload()
$this->assertInstanceOf(SoapyBaseClient::class, $client);
}

public function testCreatingClientWithCustomOverload()
public function test_creating_client_with_custom_overload()
{
$baseClient = TestSoapyClient::class;

Expand Down
Loading