CMake: fix -Wint-conversion warning (error if clang is used as MPIC_C) #777
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using of single quotes for
printf
argument within MPI_C check of CMakeLists.txt results in warning of conversion to int. The single quotes is used for char/int but not for char* type where the double quotes should be used.If clang is used as MPI_C instead of gcc the configuration is failed with error:
incompatible integer to pointer conversion passing 'int' to parameter of type 'const char *' [-Wint-conversion]
(refer Gentoo [guru overlay] issue:https://bugs.gentoo.org/888009)
Summary of changes
Fix
-Wint-conversion
warning that results in CMake configuration error ifclang
is used asMPI_C
compiler.Rationale for changes
The presence of downstream issue (Gentoo Linux [guru overlay]): https://bugs.gentoo.org/888009
Additional info and certifications
This pull request (PR) is a:
I certify that
OpenCoarrays developer a chance to review my proposed code
be introduced)
Code coverage data