Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defect: install.sh has problem with flag -r #617

Closed
dtabell opened this issue Dec 7, 2018 · 4 comments
Closed

Defect: install.sh has problem with flag -r #617

dtabell opened this issue Dec 7, 2018 · 4 comments
Assignees

Comments

@dtabell
Copy link

dtabell commented Dec 7, 2018

Defect/Bug Report

  • OpenCoarrays Version: 2.3.1
  • Fortran Compiler: 7.3.1 (but wanting to install newer)
  • C compiler used for building lib: 7.3.1
  • Installation method: install.sh
  • Output of uname -a: Linux v.radia.run 4.18.19-100.fc27.x86_64 tests dis_transpose: test passed  #1 SMP Wed Nov 14 22:04:34 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
  • MPI library being used: Open MPI 2.1.1
  • Machine architecture and number of physical cores: VM on Mac OS X with 4 cores
  • Version of CMake: 3.11.2

Observed Behavior

OpenCoarrays# ./install.sh -j 4 -p gcc -I 8.2.0 -r /opt --disable-bootstrap
2018-12-07 21:03:29 UTC [ info] __file: /home/vagrant/sw/OpenCoarrays/install.sh
2018-12-07 21:03:29 UTC [ info] __dir: /home/vagrant/sw/OpenCoarrays
2018-12-07 21:03:29 UTC [ info] __base: install
2018-12-07 21:03:29 UTC [ info] __os: Linux
2018-12-07 21:03:29 UTC [ info] __usage: /home/vagrant/sw/OpenCoarrays/install.sh-usage
2018-12-07 21:03:29 UTC [ info] LOG_LEVEL: 6
2018-12-07 21:03:29 UTC [ info] -b (--install-branch):
2018-12-07 21:03:29 UTC [ info] -B (--list-branches):
2018-12-07 21:03:29 UTC [ info] -c (--with-c):
2018-12-07 21:03:29 UTC [ info] -C (--with-cxx):
2018-12-07 21:03:29 UTC [ info] -d (--debug): 0
2018-12-07 21:03:29 UTC [ info] -D (--print-downloader):
2018-12-07 21:03:29 UTC [ info] -e (--verbose): 0
2018-12-07 21:03:29 UTC [ info] -f (--with-fortran):
2018-12-07 21:03:29 UTC [ info] -h (--help): 0
2018-12-07 21:03:29 UTC [ info] -i (--install-prefix): /home/vagrant/sw/OpenCoarrays/prerequisites/installations//
2018-12-07 21:03:29 UTC [ info] -I (--install-version): 8.2.0
2018-12-07 21:03:29 UTC [ info] -j (--num-threads): 4
2018-12-07 21:03:29 UTC [ info] -l (--list-packages): 0
2018-12-07 21:03:29 UTC [ info] -m (--with-cmake):
2018-12-07 21:03:29 UTC [ info] -M (--with-mpi):
2018-12-07 21:03:29 UTC [ info] -n (--no-color): 0
2018-12-07 21:03:29 UTC [ info] -o (--only-download): 0
2018-12-07 21:03:29 UTC [ info] -p (--package): gcc
2018-12-07 21:03:29 UTC [ info] -P (--print-path):
2018-12-07 21:03:29 UTC [ info] -r (--prefix-root): /opt
2018-12-07 21:03:29 UTC [ info] -u (--from-url):
2018-12-07 21:03:29 UTC [ info] -U (--print-url):
2018-12-07 21:03:29 UTC [ info] -v (--version): 0
2018-12-07 21:03:29 UTC [ info] -V (--print-version):
2018-12-07 21:03:29 UTC [ info] -y (--yes-to-all): 0
2018-12-07 21:03:29 UTC [ info] -Z (--bootstrap): 0
2018-12-07 21:03:29 UTC [ info] num_threads="4"
2018-12-07 21:03:29 UTC [ info] opencoarrays_src_dir=/home/vagrant/sw/OpenCoarrays
2018-12-07 21:03:29 UTC [ info] build_path="/home/vagrant/sw/OpenCoarrays"/prerequisites/builds
2018-12-07 21:03:29 UTC [ info] build_script="/home/vagrant/sw/OpenCoarrays"/prerequisites/build.sh
2018-12-07 21:03:29 UTC [ info] Invoking build script with the following command:
2018-12-07 21:03:29 UTC [ info] "/home/vagrant/sw/OpenCoarrays"/prerequisites/build.sh -j 4 -p gcc -I 8.2.0 -r /opt --disable-bootstrap
2018-12-07 21:03:29 UTC [ info] __file: /home/vagrant/sw/OpenCoarrays/prerequisites/build.sh
2018-12-07 21:03:29 UTC [ info] __dir: /home/vagrant/sw/OpenCoarrays/prerequisites
2018-12-07 21:03:29 UTC [ info] __base: build
2018-12-07 21:03:29 UTC [ info] __os: Linux
2018-12-07 21:03:29 UTC [ info] __usage: /home/vagrant/sw/OpenCoarrays/prerequisites/build.sh-usage
2018-12-07 21:03:29 UTC [ info] LOG_LEVEL: 6
2018-12-07 21:03:29 UTC [ info] -b (--install-branch):
2018-12-07 21:03:29 UTC [ info] -B (--list-branches):
2018-12-07 21:03:29 UTC [ info] -c (--with-c): gcc
2018-12-07 21:03:29 UTC [ info] -C (--with-cxx): g++
2018-12-07 21:03:29 UTC [ info] -d (--debug): 0
2018-12-07 21:03:29 UTC [ info] -D (--print-downloader):
2018-12-07 21:03:29 UTC [ info] -e (--verbose): 0
2018-12-07 21:03:29 UTC [ info] -f (--with-fortran): gfortran
2018-12-07 21:03:29 UTC [ info] -h (--help): 0
2018-12-07 21:03:29 UTC [ info] -i (--install-prefix): /home/vagrant/sw/OpenCoarrays/prerequisites/installations/
2018-12-07 21:03:29 UTC [ info] -j (--num-threads): 4
2018-12-07 21:03:29 UTC [ info] -I (--install-version): 8.2.0
2018-12-07 21:03:29 UTC [ info] -l (--list-packages): 0
2018-12-07 21:03:29 UTC [ info] -m (--with-cmake): cmake
2018-12-07 21:03:29 UTC [ info] -M (--with-mpi):
2018-12-07 21:03:29 UTC [ info] -n (--no-color): 0
2018-12-07 21:03:29 UTC [ info] -p (--package): gcc
2018-12-07 21:03:29 UTC [ info] -P (--print-path):
2018-12-07 21:03:29 UTC [ info] -t (--with-tau): tauf90
2018-12-07 21:03:29 UTC [ info] -u (--from-url):
2018-12-07 21:03:29 UTC [ info] -U (--print-url):
2018-12-07 21:03:29 UTC [ info] -v (--version): 0
2018-12-07 21:03:29 UTC [ info] -V (--print-version):
2018-12-07 21:03:29 UTC [ info] -y (--yes-to-all): 0
2018-12-07 21:03:29 UTC [ info] -Z (--bootstrap): 0
2018-12-07 21:03:29 UTC [ info] Checking available download mechanisms: ftp, wget, and curl.
2018-12-07 21:03:29 UTC [ info] ${package_name}=gcc ${arg_b:-${arg_B:-}}=
2018-12-07 21:03:29 UTC [ info] KEY=gcc VALUE=https://ftpmirror.gnu.org/gcc/gcc-8.2.0/
2018-12-07 21:03:29 UTC [emergency] Please pass only one of {-i,-r} or a longer equivalent (multiple detected). [exit 105]
2018-12-07 21:03:29 UTC [ info] Cleaning up. Done
2018-12-07 21:03:29 UTC [ info] Cleaning up. Done

Note the error message: "Please pass only one of {-i,-r} or a longer equivalent (multiple detected). [exit 105]"
But I did not pass the -i flag! Only the -r.

Expected Behavior

I expected the install prefix to automatically become /opt/gcc/8.2.0 or /opt/gnu/8.2.0

Steps to Reproduce

run the install script: ./install.sh -j 4 -p gcc -I 8.2.0 -r /opt --disable-bootstrap

@zbeekman
Copy link
Collaborator

@rouson Can you please investigate this?

Thanks!

@rouson
Copy link
Member

rouson commented Dec 12, 2018

@dtabell This was a very quick fix. PR #620 fixes this. Once the Travis-CI tests pass, the fix will be merged into the master branch and will appear in the next release. If all works as it should this issue will get closed automatically when the commit message that references this issue is merged into the master branch.

@dtabell
Copy link
Author

dtabell commented Dec 13, 2018

@rouson Cool! Thanks for addressing this issue so quickly.

@rouson rouson closed this as completed in d86b7a6 Dec 18, 2018
rouson added a commit that referenced this issue Dec 18, 2018
@ghost ghost removed the needs-review label Dec 18, 2018
@rouson
Copy link
Member

rouson commented Dec 18, 2018

@dtabell The fix for issue #617 is now on the master branch of OpenCoarrays. Please let us know if it works for you. As hoped, this issue closed automatically when I merged the commit that referenced the issue into master with the "Fix #617" text in the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants