fix: Tier module fixes and improvements (part 4) #13
Conversation
…nd query.proto messages; run proto-go
…enesis, update tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #13 +/- ##
==========================================
+ Coverage 28.53% 29.27% +0.74%
==========================================
Files 148 148
Lines 6225 6233 +8
==========================================
+ Hits 1776 1825 +49
+ Misses 4336 4298 -38
+ Partials 113 110 -3 ☔ View full report in Codecov by Sentry. |
…nticalUnlockingLockups
iverc
changed the title
| if sinceCurrentEpoch < epochDurationMs { | ||
| credit = credit.MulRaw(sinceCurrentEpoch).QuoRaw(epochDurationMs) | ||
| } |
There was a problem hiding this comment.
question/future refactor.
We might want to be more aware of what functions are public/private on the Keeper, or more accurately what functions need to be public.
Reading through some of these Add/Subtract methods makes me feel like they are mostly necessary for the internal functionality to the keeper. Compared to the possibility of another dev using these unnecessarily or accidentally from a different package.
Just a thought. Dont need to be updated in this PR
There was a problem hiding this comment.
Agree, we should be more accurate on what needs to be public. Will make these changes in the upcoming PR. Thank you
| // LockupKeyToAddressesAtHeight retreives delAddr, valAddr, and creationHeight from provided unlocking Lockup key. | ||
| func LockupKeyToAddressesAtHeight(key []byte) (sdk.AccAddress, sdk.ValAddress, int64) { |
There was a problem hiding this comment.
suggestion: Are the LockupKeyToAddressesAtHeight not still handy util functions to have around?
Description
This PR aims to add a number of fixes and additional improvements on top of work done in #10
Tasks
UnlockingLockup, refactorLockup,GenesisState, and query messages.unbondTimetocompletionTimeto match native staking module.creation_heighttoMsgUnlockResponse.GenesisState.calculateProratedCredit.completionTime/unlockTimeedge case inCompleteUnlocking.proratedCredit, addTestCalculateProratedCreditandTestProratedCredit.