fix: Notify subscribers on close #876
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
Codecov Report
@@ Coverage Diff @@
## develop #876 +/- ##
===========================================
+ Coverage 59.81% 59.82% +0.01%
===========================================
Files 157 158 +1
Lines 17425 17438 +13
===========================================
+ Hits 10422 10432 +10
- Misses 6066 6068 +2
- Partials 937 938 +1
|
|
Closed, as is a Golang prop to handle this already that I didnt know about (thanks Fred lol) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #872
Description
An alternative pattern to that in #873
Specify the platform(s) on which this was tested: