fix: Handle filter input field argument being nil #787
+10
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadlone
added
bug
shahzadlone
commented
Sep 12, 2022
AndrewSisley
previously requested changes
Sep 12, 2022
shahzadlone
force-pushed
the
lone/fix/nil-filter-input-type
branch
3 times, most recently
from
9d10cbd to
b9ec3d1
Compare
shahzadlone
force-pushed
the
lone/fix/nil-filter-input-type
branch
from
b9ec3d1 to
244c10a
Compare
Have updated PR description with the new changes with John's help which fixes the bug. |
…eldList according to Johns suggestion. Update the schema tests that also fixes an order field.
shahzadlone
force-pushed
the
lone/fix/nil-filter-input-type
branch
from
244c10a to
dae09a5
Compare
shahzadlone
commented
Sep 18, 2022
| @@ -281,7 +281,7 @@ var defaultBookArgsWithoutFilter = trimFields( | |||
| buildOrderArg("book", []argDef{ | |||
| { | |||
| fieldName: "author", | |||
| typeName: "", | |||
| typeName: "authorOrderArg", | |||
There was a problem hiding this comment.
thought: Potentially fixes another bug with Order input type.
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Resolves: sourcenetwork#784 * Description: - In `generate.go`.genTypeFilterArgInput where if a [field.Type + "FilterArg"] key didn't exist in the `typeMap` it would return nil and pass that to `InputObjectFieldConfig` as Type. - Modify the way `AppendType` was being used in `genTypeQueryableFieldList`. We do direct manipulation of the TypeMap, such that it won't cause any errors. We do still get the benefits of `AppendType` because of our `ResolveType` function (we want to avoid resolving `FieldThunk` too early), - Another schema type generation bug was fixed by the above change where the `OrderArg` for the relation field name would have the type as empty string `""` instead of `"XOrderArg"`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #784
Similar to #701 (PR), #700 (ISSUE)
Description
generate.go.genTypeFilterArgInput where if a [field.Type + "FilterArg"] key didn't exist in thetypeMapit would return nil and pass that toInputObjectFieldConfigas Type.AppendTypewas being used ingenTypeQueryableFieldList. We do direct manipulation of the TypeMap, such that it won't cause any errors. We do still get the benefits ofAppendTypebecause of ourResolveTypefunction (we want to avoid resolvingFieldThunktoo early),OrderArgfor the relation field name would have the type as empty string""instead of"XOrderArg".How has this been tested?
Local & CI
Specify the platform(s) on which this was tested: