-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Rename all Query terminology to Request #497
refactor: Rename all Query terminology to Request #497
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #497 +/- ##
===========================================
+ Coverage 65.09% 65.11% +0.01%
===========================================
Files 87 88 +1
Lines 10242 10242
===========================================
+ Hits 6667 6669 +2
+ Misses 2927 2925 -2
Partials 648 648
|
ah.... I didnt realize you'd end up moving the planner/parser packages.... How long did you spend on this? Is it quick to do? Am quite nervous about missing changes in develop in the doc restructure branch if you are moving these files (doc restructure is close to proper PR status now) |
request plan was being called Query.
76e6cbd
to
f5f45af
Compare
This is why I mentioned in the last meeting that we will have notable conflicts with your stuff. Nothing to worry this is all fairly easy to patch on top of your work once it is in, it should be straight forward from my end as this didn't take too much time (most of the work was done with vim macros and tools). Will say this definitely should happen after your stuff is in (or even later if there are any other major conflicting PR changes). Additionally adding the |
Ah sorry, I guess I'd either forgotten that or didn't realize the impact of you moving files (and thought it would just be simple/normal conflicts)
Cheers! Will review properly after the standup then |
@@ -152,7 +153,7 @@ func (hf *HeadFetcher) Close() error { | |||
// List returns the list of current heads plus the max height. | |||
// @todo Document Heads.List function | |||
func (hh *heads) List() ([]cid.Cid, uint64, error) { | |||
q := query.Query{ | |||
q := dsRequest.Query{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
undo
Closing for: #1054 |
RELEVANT ISSUE(S)
Resolves #455
DESCRIPTION
Change the codebase Query terminology to use the word
Request
to address the top levelQuery Request
and to use the wordquery
to address theRead-only Operation
to avoid confusion.HOW HAS THIS BEEN TESTED?
Locally and CI.
CHECKLIST:
ENVIRONMENT / OS THIS WAS TESTED ON?
Please specify which of the following was this tested on (remove or add your own):