-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Multiple schema file support in schema add #3352
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3352 +/- ##
===========================================
+ Coverage 78.10% 78.38% +0.27%
===========================================
Files 388 392 +4
Lines 35398 35650 +252
===========================================
+ Hits 27647 27941 +294
+ Misses 6119 6069 -50
- Partials 1632 1640 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 37 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -20,6 +19,8 @@ import ( | |||
"github.com/sourcenetwork/corelog" | |||
"github.com/spf13/pflag" | |||
"github.com/spf13/viper" | |||
|
|||
"github.com/sourcenetwork/defradb/errors" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Might be worth adding a linter rule for this check.
Relevant issue(s)
Resolves #1248
Description
Previously, a single schema file could be added by calling
defradb schema add -f filename
. Now we can add multiple new schemas from different files in the following way:defradb schema add -f file_one -f file_two -f file_three
This PR also adjusts some import statements that were using the incorrect
error
import.Tasks
How has this been tested?
Specify the platform(s) on which this was tested: