Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Remove dependency building step before benchmarking #335

Closed
wants to merge 2 commits into from
Closed

ci: Remove dependency building step before benchmarking #335

wants to merge 2 commits into from

Conversation

shahzadlone
Copy link
Member

resolves #334

Removes the dependency building step in before doing benchmarking comparisons, because our new AMI image has
bench stat on it.

@shahzadlone shahzadlone added this to the DefraDB v0.3 milestone Apr 8, 2022
@shahzadlone shahzadlone self-assigned this Apr 8, 2022
@shahzadlone
Copy link
Member Author

TODO: Fix the ci bug where bench-stat isn't being called properly

@jsimnz
Copy link
Member

jsimnz commented Apr 8, 2022

TODO: Fix the ci bug where bench-stat isn't being called properly

Is this TODO still outstanding, or should I review/approve now?

@jsimnz jsimnz added ci/build This is issue is about the build or CI system, and the administration of it. meta/dev These issues related to the meta elements of the code base like dev flow, repo logistics, and PM and removed todo 🗒️ labels Apr 8, 2022
@sourcenetwork sourcenetwork deleted a comment from source-devs Apr 9, 2022
@source-devs
Copy link

Benchmark Results

Summary

  • 0 Benchmarks successfully compared.
  • 0 Benchmarks were ✅ Better.
  • 0 Benchmarks were ❌ Worse .
  • 0 Benchmarks were ✨ Unchanged.
✅ See Better Results...
time/opdelta
 
❌ See Worse Results...
time/opdelta
 
✨ See Unchanged Results...
time/opdelta
 
🐋 See Full Results...

@shahzadlone shahzadlone closed this Apr 9, 2022
@shahzadlone shahzadlone deleted the lone/ci/remove-benchmarking-dependency branch July 18, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shahzadlone shahzadlone

Labels
ci/build This is issue is about the build or CI system, and the administration of it. meta/dev These issues related to the meta elements of the code base like dev flow, repo logistics, and PM
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.

Store benchmark dependency in the AMI image.
3 participants
@shahzadlone @jsimnz @source-devs