fix(i): Panic in object equal filter #3143
Conversation
nasdf
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3143 +/- ##
===========================================
- Coverage 78.13% 78.04% -0.09%
===========================================
Files 353 353
Lines 34647 34647
===========================================
- Hits 27068 27038 -30
- Misses 5965 5987 +22
- Partials 1614 1622 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| d := data.(map[string]any) | ||
| if len(d) != len(condition) { | ||
| d, ok := data.(map[string]any) | ||
| if !ok || len(d) != len(condition) { |
There was a problem hiding this comment.
suggestion: It would be worth documenting how this can come about, especially given that it was missed originally. Otherwise someone in the future may remove it (and hopefully hit the test, but it will still cost time).
There was a problem hiding this comment.
I've added a developer note to the connor.go header since this will apply to all operators moving forward.
There was a problem hiding this comment.
Okay cheers, I am somewhat sceptical as to whether people will usually read/remember that before reading this line(s), but it saves duplicating the comment in a bunch of places and we can move it inline in the future if people end up tripping up on this.
I'm noticing a few other areas that will have a similar bug. The filters were originally written to be somewhat type safe, but we can't rely on that because the JSON type can be anything. |
Relevant issue(s)
Resolves #3141
Description
This PR fixes a bug where the object equality check would panic when comparing with a non object type.
Tasks
How has this been tested?
Added integration test.
Specify the platform(s) on which this was tested: