-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable Indexing of array fields #3092
feat: Enable Indexing of array fields #3092
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3092 +/- ##
===========================================
+ Coverage 79.81% 79.99% +0.18%
===========================================
Files 351 352 +1
Lines 27335 27757 +422
===========================================
+ Hits 21816 22204 +388
- Misses 3982 3987 +5
- Partials 1537 1566 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part way through reviewing, looks really great so far, only very localised comments atm :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good Islam, just a couple more todos from me before merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good Islam, thanks for this :)
Relevant issue(s)
Resolves #2279
Description
Enable indexing of array fields.
This change also adds
IsEqual
method toNormalValue
.