Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: GraphQL order input #3044

Merged
merged 6 commits into from
Sep 24, 2024

Merge branch 'develop' into nasdf/refactor/gql-order-list-arg

497160c
Select commit
Loading
Failed to load commit list.
Merged

refactor: GraphQL order input #3044

Merge branch 'develop' into nasdf/refactor/gql-order-list-arg
497160c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 24, 2024 in 1s

79.50% (+0.10%) compared to 228fb99

View this Pull Request on Codecov

79.50% (+0.10%) compared to 228fb99

Details

Codecov Report

Attention: Patch coverage is 81.53846% with 12 lines in your changes missing coverage. Please review.

Project coverage is 79.50%. Comparing base (228fb99) to head (497160c).

Files with missing lines Patch % Lines
internal/request/graphql/parser/order.go 78.72% 6 Missing and 4 partials ⚠️
internal/request/graphql/parser/filter.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3044      +/-   ##
===========================================
+ Coverage    79.40%   79.50%   +0.10%     
===========================================
  Files          342      343       +1     
  Lines        26514    26511       -3     
===========================================
+ Hits         21052    21075      +23     
+ Misses        3942     3927      -15     
+ Partials      1520     1509      -11     
Files with missing lines Coverage Δ
internal/request/graphql/parser/commit.go 87.30% <100.00%> (ø)
internal/request/graphql/parser/query.go 90.86% <100.00%> (+4.84%) ⬆️
internal/request/graphql/schema/generate.go 87.97% <100.00%> (ø)
internal/request/graphql/schema/types/commits.go 100.00% <100.00%> (ø)
internal/request/graphql/parser/filter.go 67.69% <33.33%> (-0.58%) ⬇️
internal/request/graphql/parser/order.go 78.72% <78.72%> (ø)

... and 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 228fb99...497160c. Read the comment docs.