fix: Ignore badger path if in-memory

[ONLYUSEmePHONE]

Relevant issue(s)

Resolves #2964

Description

Small change that now only sets the badger options Dir and ValueDir to the path parameter if the badger option InMemory is not true.

The crash was happening because badger expects the two Dir values to be nil if InMemory is true.

I chose this fix because it's very simple and requires the least changes. The bulk of the problem is that the datastore.badger.path config value gets set to data by default regardless of whether datastore.store is set to memory and this value gets passed as the path parameter. I didn't think it would be nice to change any of the upstream logic or the signature of the NewDatastore function.

Tasks

• I made sure the code is well commented, particularly hard-to-understand areas.
• I made sure the repository-held documentation is changed accordingly.
• I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
• I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Running standard test suite and using both commands provided in #2964 .

Specify the platform(s) on which this was tested:

• Debian Linux

[AndrewSisley]

@ONLYUSEmePHONE Hey, and welcome to our codebase!

Thank you very much for this fix, it solves the bigger problem, and is very minimal as you noted in the description :)

[AndrewSisley]

FYI: I'm going to update the PR title, hope you don't mind - we have a 60 character limit (I also rebased onto the latest, also a requirement for merge)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.35%. Comparing base (2d1702c) to head (9ae49f5).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2967      +/-   ##
===========================================
+ Coverage    79.34%   79.35%   +0.01%     
===========================================
  Files          326      326              
  Lines        24768    24769       +1     
===========================================
+ Hits         19651    19655       +4     
+ Misses        3704     3702       -2     
+ Partials      1413     1412       -1     

Flag	Coverage Δ
all-tests	79.35% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
datastore/badger/v4/datastore.go	81.37% <100.00%> (+0.05%)	⬆️

... and 14 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d1702c...9ae49f5. Read the comment docs.