Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump grpc version #2824

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #2823

Description

Bump grpc version. 1.64 has a security issue

@AndrewSisley AndrewSisley added the bump Bumped version for something label Jul 9, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.13 milestone Jul 9, 2024
@AndrewSisley AndrewSisley requested a review from a team July 9, 2024 18:53
@AndrewSisley AndrewSisley self-assigned this Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.21%. Comparing base (bfa791d) to head (187e4cf).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2824      +/-   ##
===========================================
- Coverage    79.21%   79.21%   -0.01%     
===========================================
  Files          321      321              
  Lines        24281    24281              
===========================================
- Hits         19234    19232       -2     
  Misses        3667     3667              
- Partials      1380     1382       +2     
Flag Coverage Δ
all-tests 79.21% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfa791d...187e4cf. Read the comment docs.

Copy link
Member

@nasdf nasdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzadlone
Copy link
Member

Not sure why dependabot didn't pick this update.

Dependabot opened this for some reason: #2825

@AndrewSisley AndrewSisley force-pushed the 2823-grpc-v branch 2 times, most recently from 71504d9 to 774e5e4 Compare July 15, 2024 15:44
@shahzadlone
Copy link
Member

Dependabot came around:
#2831

1.64 has a security issue
@AndrewSisley AndrewSisley merged commit ff03efe into sourcenetwork:develop Jul 15, 2024
37 of 39 checks passed
@AndrewSisley AndrewSisley deleted the 2823-grpc-v branch July 15, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump Bumped version for something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump grpc version
3 participants