Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Race condition when testing CLI #2713

Merged
merged 1 commit into from
Jun 12, 2024

replace global package flags

cbee936
Select commit
Loading
Failed to load commit list.
Merged

fix: Race condition when testing CLI #2713

replace global package flags
cbee936
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 12, 2024 in 1s

77.87% (-0.08%) compared to d15b3b3, passed because coverage increased by -0.01% when compared to adjusted base (77.87%)

View this Pull Request on Codecov

77.87% (-0.08%) compared to d15b3b3, passed because coverage increased by -0.01% when compared to adjusted base (77.87%)

Details

Codecov Report

Attention: Patch coverage is 94.68085% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.87%. Comparing base (d15b3b3) to head (cbee936).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2713      +/-   ##
===========================================
- Coverage    77.95%   77.87%   -0.08%     
===========================================
  Files          310      310              
  Lines        23120    23113       -7     
===========================================
- Hits         18022    17998      -24     
- Misses        3717     3728      +11     
- Partials      1381     1387       +6     
Files Coverage Δ
cli/utils.go 74.07% <100.00%> (ø)
cli/start.go 44.83% <97.87%> (-0.47%) ⬇️
cli/config.go 83.67% <75.00%> (-1.51%) ⬇️
cli/root.go 97.47% <94.74%> (-0.03%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d15b3b3...cbee936. Read the comment docs.