feat: Multiple docs with nil value on unique-indexed field #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islamaliev
added
area/query
islamaliev
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2276 +/- ##
===========================================
+ Coverage 74.02% 74.22% +0.20%
===========================================
Files 256 256
Lines 25740 25789 +49
===========================================
+ Hits 19052 19141 +89
+ Misses 5366 5333 -33
+ Partials 1322 1315 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
AndrewSisley
approved these changes
Feb 6, 2024
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…work#2276) ## Relevant issue(s) Resolves sourcenetwork#2180 ## Description Allow multiple docs with nil value on unique-indexed field. This change also included few minor query optimizations that involve secondary indexes. Explain request is slightly adjusted not to increase field fetches count upon fetching indexes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #2180
Description
Allow multiple docs with nil value on unique-indexed field.
This change also included few minor query optimizations that involve secondary indexes.
Explain request is slightly adjusted not to increase field fetches count upon fetching indexes.
Tasks
How has this been tested?
Unit and integration tests.
Specify the platform(s) on which this was tested: