Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Convert filter explain tests to new explain setup #1380

Merged
merged 6 commits into from
Apr 21, 2023
Merged

test: Convert filter explain tests to new explain setup #1380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c1ad8ed
PR: Fix ExpectedError testing for new setup.
shahzadlone Mar 3, 2023
b36d27c
PR: Fix test framework bug, fail on wrong usage.
shahzadlone Apr 20, 2023
d6057a7
PR: Add a fixture and rename the explain helper.
shahzadlone Apr 20, 2023
b1c5de6
PR: Convert the basic test.
shahzadlone Apr 20, 2023
ba8e9e9
PR: Convert the filter explain tests.
shahzadlone Apr 20, 2023
7b9cf17
PR: Remove the example tests now.
shahzadlone Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 18 additions & 89 deletions tests/integration/explain/default/basic_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,16 @@ package test_explain_default
import (
"testing"

testUtils "github.com/sourcenetwork/defradb/tests/integration"
explainUtils "github.com/sourcenetwork/defradb/tests/integration/explain"
)

func TestExplainQuerySimpleOnFieldDirective_BadUsage(t *testing.T) {
test := testUtils.RequestTestCase{
func TestDefaultExplainOnWrongFieldDirective_BadUsage(t *testing.T) {
test := explainUtils.ExplainRequestTestCase{

Description: "Explain a query by providing the directive on wrong location (field).",
Description: "Explain (default) a request by providing the directive on wrong location (field).",

Request: `query {
author @explain {
_key
name
age
}
Expand All @@ -40,16 +39,17 @@ func TestExplainQuerySimpleOnFieldDirective_BadUsage(t *testing.T) {

ExpectedError: "Directive \"explain\" may not be used on FIELD.",
}
executeTestCase(t, test)

runExplainTest(t, test)
}

func TestExplainQuerySimple(t *testing.T) {
test := testUtils.RequestTestCase{
Description: "Explain a query with no filter",
func TestDefaultExplainRequestWithFullBasicGraph(t *testing.T) {
test := explainUtils.ExplainRequestTestCase{

Description: "Explain (default) a basic request.",

Request: `query @explain {
author {
_key
name
age
}
Expand All @@ -64,7 +64,7 @@ func TestExplainQuerySimple(t *testing.T) {
},
},

Results: []dataMap{
ExpectedFullGraph: []dataMap{
{
"explain": dataMap{
"selectTopNode": dataMap{
Expand All @@ -88,12 +88,13 @@ func TestExplainQuerySimple(t *testing.T) {
},
}

executeTestCase(t, test)
runExplainTest(t, test)
}

func TestExplainQuerySimpleWithAlias(t *testing.T) {
test := testUtils.RequestTestCase{
Description: "Explain a query with alias, no filter",
func TestDefaultExplainWithAlias(t *testing.T) {
test := explainUtils.ExplainRequestTestCase{

Description: "Explain (default) a basic request with alias, no filter",

Request: `query @explain {
author {
Expand All @@ -111,80 +112,8 @@ func TestExplainQuerySimpleWithAlias(t *testing.T) {
},
},

Results: []dataMap{
{
"explain": dataMap{
"selectTopNode": dataMap{
"selectNode": dataMap{
"filter": nil,
"scanNode": dataMap{
"filter": nil,
"collectionID": "3",
"collectionName": "author",
"spans": []dataMap{
{
"start": "/3",
"end": "/4",
},
},
},
},
},
},
},
},
}

executeTestCase(t, test)
}

func TestExplainQuerySimpleWithMultipleRows(t *testing.T) {
test := testUtils.RequestTestCase{
Description: "Explain a query with no filter, mutiple rows",

Request: `query @explain {
author {
name
age
}
}`,

Docs: map[int][]string{
2: {
`{
"name": "John",
"age": 21
}`,
`{
"name": "Bob",
"age": 27
}`,
},
},

Results: []dataMap{
{
"explain": dataMap{
"selectTopNode": dataMap{
"selectNode": dataMap{
"filter": nil,
"scanNode": dataMap{
"filter": nil,
"collectionID": "3",
"collectionName": "author",
"spans": []dataMap{
{
"start": "/3",
"end": "/4",
},
},
},
},
},
},
},
},
ExpectedPatterns: []dataMap{basicPattern},
}

executeTestCase(t, test)
runExplainTest(t, test)
}
238 changes: 0 additions & 238 deletions tests/integration/explain/default/example_new_basic_test.go
View file
Open in desktop

This file was deleted.

Loading