Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linters deadcode and varcheck deprecated in golangci-lint v1.49 #817

Closed
orpheuslummis opened this issue Sep 18, 2022 · 5 comments · Fixed by #818
Closed

linters deadcode and varcheck deprecated in golangci-lint v1.49 #817

orpheuslummis opened this issue Sep 18, 2022 · 5 comments · Fixed by #818
Assignees
@shahzadlone
Labels
ci/build This is issue is about the build or CI system, and the administration of it.
Milestone
DefraDB v0.5

Comments

@orpheuslummis
Copy link
Contributor

No description provided.

@orpheuslummis orpheuslummis added the ci/build This is issue is about the build or CI system, and the administration of it. label Sep 18, 2022
@shahzadlone
Copy link
Member

You beat me to it.

One thing to keep in mind is this is only an issue locally for now as our CI is locked to a version before this.

@orpheuslummis
Copy link
Contributor Author

orpheuslummis commented Sep 18, 2022 •
edited
Loading

unsure, but I suggest we find replacements for the functionalities of these 'lost' linters, if possible

@shahzadlone
Copy link
Member

No, they were deprecated because they were doing repetitive tasks (similar to unused and some others). When we bump our CI to 1.49 we can handle this, it's a trivial fix.

@orpheuslummis
Copy link
Contributor Author

ok, nice

@shahzadlone shahzadlone mentioned this issue Sep 18, 2022
Merged
@shahzadlone
Copy link
Member

shahzadlone commented Sep 18, 2022 •
edited
Loading

Blocked until this is fixed: golangci/golangci-lint-action#540
Because of this issue: golangci/golangci-lint-action#535

The issue that made us hard code to version v1.47 still persists (#727) lint action uses the default built binary that enforces go v1.19 formatting.

suggest waiting for this until that is fixed (or else we would manually have to build golang-ci every time in the CI).

Or until we bump to GoLang v1.19

@shahzadlone shahzadlone mentioned this issue Feb 2, 2023
Closed
@shahzadlone shahzadlone self-assigned this Feb 14, 2023
@shahzadlone shahzadlone added this to the DefraDB v0.5 milestone Feb 14, 2023
shahzadlone added a commit that referenced this issue Feb 15, 2023
@shahzadlone
chore: Bump to GoLang v1.19 (#818)
07dfd1e 
- Resolves #817
- Resolves #1070 

- This PR was initially started as: `ci: Bump workflow's golang-ci lint version` to fix the golang-ci lint issue. This work that was done in this PR was the following:
  - Remove the `deadcode` and `varcheck` linters that are now deprecated with `v1.49`
  - Remove all `nolint` directives where the deprecated linters were being referenced.
  - Update CI's linter version to use the latest version.

However as the golang-ci lint team still didn't fix that issue but golang1.19 was released we can just fix those errors and bump the GoLang version for defradb and keeping the previous linter fixes.

Inaddtion also re-enabling the `goheader` linter rule as the change was somehow dropped when we released defradb v0.4.
shahzadlone added a commit that referenced this issue Apr 13, 2023
@shahzadlone
chore: Bump to GoLang v1.19 (#818)
0684901 
- Resolves #817
- Resolves #1070 

- This PR was initially started as: `ci: Bump workflow's golang-ci lint version` to fix the golang-ci lint issue. This work that was done in this PR was the following:
  - Remove the `deadcode` and `varcheck` linters that are now deprecated with `v1.49`
  - Remove all `nolint` directives where the deprecated linters were being referenced.
  - Update CI's linter version to use the latest version.

However as the golang-ci lint team still didn't fix that issue but golang1.19 was released we can just fix those errors and bump the GoLang version for defradb and keeping the previous linter fixes.

Inaddtion also re-enabling the `goheader` linter rule as the change was somehow dropped when we released defradb v0.4.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
chore: Bump to GoLang v1.19 (sourcenetwork#818)
d08c38f 
- Resolves sourcenetwork#817
- Resolves sourcenetwork#1070 

- This PR was initially started as: `ci: Bump workflow's golang-ci lint version` to fix the golang-ci lint issue. This work that was done in this PR was the following:
  - Remove the `deadcode` and `varcheck` linters that are now deprecated with `v1.49`
  - Remove all `nolint` directives where the deprecated linters were being referenced.
  - Update CI's linter version to use the latest version.

However as the golang-ci lint team still didn't fix that issue but golang1.19 was released we can just fix those errors and bump the GoLang version for defradb and keeping the previous linter fixes.

Inaddtion also re-enabling the `goheader` linter rule as the change was somehow dropped when we released defradb v0.4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzadlone shahzadlone

Labels
ci/build This is issue is about the build or CI system, and the administration of it.
Projects
None yet
Milestone
DefraDB v0.5
Development

Successfully merging a pull request may close this issue.

chore: Bump to GoLang v1.19 sourcenetwork/defradb
2 participants
@orpheuslummis @shahzadlone