Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestQuerySimpleWithCid fails in change detector #3233

Closed
AndrewSisley opened this issue Nov 11, 2024 · 0 comments · Fixed by #3234
Closed

TestQuerySimpleWithCid fails in change detector #3233

AndrewSisley opened this issue Nov 11, 2024 · 0 comments · Fixed by #3234
Assignees
@AndrewSisley
Labels
area/testing Related to any test or testing suite ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality
Milestone
DefraDB v0.15

Comments

@AndrewSisley
Copy link
Contributor

Change detector doesnt support require.Panic
@AndrewSisley AndrewSisley added area/testing Related to any test or testing suite ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality labels Nov 11, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.15 milestone Nov 11, 2024
@AndrewSisley AndrewSisley self-assigned this Nov 11, 2024
@AndrewSisley AndrewSisley mentioned this issue Nov 11, 2024
Merged
islamaliev pushed a commit to islamaliev/defradb that referenced this issue Nov 13, 2024
@AndrewSisley @islamaliev
test(i): Skip test when detecting changes (sourcenetwork#3234)
009d011 
## Relevant issue(s)

Resolves sourcenetwork#3233

## Description

Skip test `TestQuerySimpleWithCid` when detecting changes as the change
detector does not support asserting panics.

Note: The CI wont pass until *after* this is merged to develop, so
someone will need to change the requiredness of the job so that this can
merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/testing Related to any test or testing suite ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality
Projects
None yet
Milestone
DefraDB v0.15
Development

Successfully merging a pull request may close this issue.

test(i): Skip test when detecting changes AndrewSisley/defradb
1 participant
@AndrewSisley