Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests setupDatabase is spinning up p2p and http servers #2643

Closed
AndrewSisley opened this issue May 23, 2024 · 0 comments · Fixed by #2644
Closed

Integration tests setupDatabase is spinning up p2p and http servers #2643

AndrewSisley opened this issue May 23, 2024 · 0 comments · Fixed by #2644
Assignees
@AndrewSisley
Labels
area/testing Related to any test or testing suite
Milestone
DefraDB v0.12

Comments

@AndrewSisley
Copy link
Contributor

And not closing them down.

Introduced by #2641
@AndrewSisley AndrewSisley added the area/testing Related to any test or testing suite label May 23, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.12 milestone May 23, 2024
@AndrewSisley AndrewSisley self-assigned this May 23, 2024
@AndrewSisley AndrewSisley mentioned this issue May 23, 2024
Merged
AndrewSisley added a commit that referenced this issue May 23, 2024
@AndrewSisley
test(i): Don't setup http and p2p by default in test suite (#2644)
3c8871a 
## Relevant issue(s)

Resolves #2643

## Description

Don't setup http and p2p by default in test suite.

This is a regression I introduced in
#2641 (sorry for the
bother) - we set p2p and http up later. As the new, unused, P2P and http
servers werent cleaned up at the end of the test, this had quite a bad
effect on test suite memory consumption.

Later, I think the surrounding code that sets up p2p and http could
probably be changed later to make better use of `node.New`, but IMO this
is good enough for now (we have other things to do).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/testing Related to any test or testing suite
Projects
None yet
Milestone
DefraDB v0.12
Development

Successfully merging a pull request may close this issue.

test(i): Don't setup http and p2p by default in test suite AndrewSisley/defradb
1 participant
@AndrewSisley