Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass acp.ACP into db.NewDB #2632

Closed
AndrewSisley opened this issue May 21, 2024 · 0 comments · Fixed by #2633
Closed

Pass acp.ACP into db.NewDB #2632

AndrewSisley opened this issue May 21, 2024 · 0 comments · Fixed by #2633
Assignees
@AndrewSisley
Labels
area/acp Related to the acp (access control) system refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Milestone
DefraDB v0.12

Comments

@AndrewSisley
Copy link
Contributor

Pass acp.ACP into db.NewDB like we do with rootstore.
@AndrewSisley AndrewSisley added refactor This issue specific to or requires *notable* refactoring of existing codebases and components area/acp Related to the acp (access control) system labels May 21, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.12 milestone May 21, 2024
@AndrewSisley AndrewSisley self-assigned this May 21, 2024
@AndrewSisley AndrewSisley mentioned this issue May 21, 2024
Merged
AndrewSisley added a commit that referenced this issue May 21, 2024
@AndrewSisley
feat: Inject ACP instance into the DB instance (#2633)
148da8f 
## Relevant issue(s)

Resolves #2632

## Description

Injects the ACP instance into the DB instance, like how rootstore is
provided.

Also makes the `acp` package public, and moves the ACP options off of
`db` and into `node` (similar to rootstore).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/acp Related to the acp (access control) system refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Milestone
DefraDB v0.12
Development

Successfully merging a pull request may close this issue.

feat: Inject ACP instance into the DB instance AndrewSisley/defradb
1 participant
@AndrewSisley