Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test flag to disable network tests #2494

Closed
nasdf opened this issue Apr 4, 2024 · 0 comments · Fixed by #2495
Closed

Add test flag to disable network tests #2494

nasdf opened this issue Apr 4, 2024 · 0 comments · Fixed by #2495
Assignees
@nasdf
Labels
area/testing Related to any test or testing suite feature New feature or request
Milestone
DefraDB v0.11

Comments

@nasdf
Copy link
Member

nasdf commented Apr 4, 2024

No description provided.

@nasdf nasdf added feature New feature or request area/testing Related to any test or testing suite labels Apr 4, 2024
@nasdf nasdf added this to the DefraDB v0.11 milestone Apr 4, 2024
@nasdf nasdf self-assigned this Apr 4, 2024
@nasdf nasdf mentioned this issue Apr 4, 2024
Merged
4 tasks
nasdf added a commit that referenced this issue Apr 5, 2024
@nasdf
test: Add flag to skip network tests (#2495)
9938518 
## Relevant issue(s)

Resolves #2494 

## Description

This PR adds a test flag set via an environment variable to skip any
tests that involve network actions.

## Tasks

- [x] I made sure the code is well commented, particularly
hard-to-understand areas.
- [x] I made sure the repository-held documentation is changed
accordingly.
- [x] I made sure the pull request title adheres to the conventional
commit style (the subset used in the project can be found in
[tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)).
- [x] I made sure to discuss its limitations such as threats to
validity, vulnerability to mistake and misuse, robustness to
invalidation of assumptions, resource requirements, ...

## How has this been tested?

`make test`

Specify the platform(s) on which this was tested:
- MacOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nasdf nasdf

Labels
area/testing Related to any test or testing suite feature New feature or request
Projects
None yet
Milestone
DefraDB v0.11
Development

Successfully merging a pull request may close this issue.

test: Add flag to skip network tests nasdf/defradb
1 participant
@nasdf