Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net config refactor #2263

Closed
Tracked by #2257
fredcarle opened this issue Jan 29, 2024 · 0 comments · Fixed by #2258
Closed
Tracked by #2257

Net config refactor #2263

fredcarle opened this issue Jan 29, 2024 · 0 comments · Fixed by #2258
Assignees
Labels
area/p2p Related to the p2p networking system
Milestone

Comments

@fredcarle
Copy link
Collaborator

No description provided.

This was referenced Jan 29, 2024
@fredcarle fredcarle added the area/p2p Related to the p2p networking system label Jan 29, 2024
@fredcarle fredcarle added this to the DefraDB v0.10 milestone Jan 29, 2024
nasdf added a commit that referenced this issue Jan 30, 2024
## Relevant issue(s)
Resolves #2263

## Description

This is part of a larger refactor of the config package.

## Tasks

- [x] I made sure the code is well commented, particularly
hard-to-understand areas.
- [x] I made sure the repository-held documentation is changed
accordingly.
- [x] I made sure the pull request title adheres to the conventional
commit style (the subset used in the project can be found in
[tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)).
- [x] I made sure to discuss its limitations such as threats to
validity, vulnerability to mistake and misuse, robustness to
invalidation of assumptions, resource requirements, ...

## How has this been tested?

make test

Specify the platform(s) on which this was tested:
- MacOS
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
## Relevant issue(s)
Resolves sourcenetwork#2263

## Description

This is part of a larger refactor of the config package.

## Tasks

- [x] I made sure the code is well commented, particularly
hard-to-understand areas.
- [x] I made sure the repository-held documentation is changed
accordingly.
- [x] I made sure the pull request title adheres to the conventional
commit style (the subset used in the project can be found in
[tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)).
- [x] I made sure to discuss its limitations such as threats to
validity, vulnerability to mistake and misuse, robustness to
invalidation of assumptions, resource requirements, ...

## How has this been tested?

make test

Specify the platform(s) on which this was tested:
- MacOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/p2p Related to the p2p networking system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants