Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blob scalar type #2090

Closed
nasdf opened this issue Nov 28, 2023 · 0 comments · Fixed by #2091
Closed

Blob scalar type #2090

nasdf opened this issue Nov 28, 2023 · 0 comments · Fixed by #2091
Assignees
@nasdf
Labels
area/schema Related to the schema system feature New feature or request
Milestone
DefraDB v0.9

Comments

@nasdf
Copy link
Member

nasdf commented Nov 28, 2023 •
edited
Loading

Adding support for a blob scalar type will simplify storage of binary objects such as images, audio files, etc. in DefraDB.
@nasdf nasdf added feature New feature or request area/schema Related to the schema system labels Nov 28, 2023
@nasdf nasdf self-assigned this Nov 28, 2023
@nasdf nasdf mentioned this issue Nov 28, 2023
Merged
4 tasks
@nasdf nasdf added this to the DefraDB v0.9 milestone Nov 28, 2023
@nasdf nasdf changed the title Bytes scalar type Blob scalar type Dec 6, 2023
nasdf added a commit that referenced this issue Dec 7, 2023
@nasdf
feat: Add blob scalar type (#2091)
9084218 
## Relevant issue(s)

Resolves #2090 

## Description

This PR adds a blob scalar type to the schema system.

## Tasks

- [x] I made sure the code is well commented, particularly
hard-to-understand areas.
- [x] I made sure the repository-held documentation is changed
accordingly.
- [x] I made sure the pull request title adheres to the conventional
commit style (the subset used in the project can be found in
[tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)).
- [x] I made sure to discuss its limitations such as threats to
validity, vulnerability to mistake and misuse, robustness to
invalidation of assumptions, resource requirements, ...

## How has this been tested?

Added integration tests.

Specify the platform(s) on which this was tested:
- MacOS
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Jan 22, 2024
@nasdf @shahzadlone
feat: Add blob scalar type (sourcenetwork#2091)
acc58dd 
## Relevant issue(s)

Resolves sourcenetwork#2090 

## Description

This PR adds a blob scalar type to the schema system.

## Tasks

- [x] I made sure the code is well commented, particularly
hard-to-understand areas.
- [x] I made sure the repository-held documentation is changed
accordingly.
- [x] I made sure the pull request title adheres to the conventional
commit style (the subset used in the project can be found in
[tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)).
- [x] I made sure to discuss its limitations such as threats to
validity, vulnerability to mistake and misuse, robustness to
invalidation of assumptions, resource requirements, ...

## How has this been tested?

Added integration tests.

Specify the platform(s) on which this was tested:
- MacOS
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@nasdf
feat: Add blob scalar type (sourcenetwork#2091)
1941f74 
## Relevant issue(s)

Resolves sourcenetwork#2090 

## Description

This PR adds a blob scalar type to the schema system.

## Tasks

- [x] I made sure the code is well commented, particularly
hard-to-understand areas.
- [x] I made sure the repository-held documentation is changed
accordingly.
- [x] I made sure the pull request title adheres to the conventional
commit style (the subset used in the project can be found in
[tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)).
- [x] I made sure to discuss its limitations such as threats to
validity, vulnerability to mistake and misuse, robustness to
invalidation of assumptions, resource requirements, ...

## How has this been tested?

Added integration tests.

Specify the platform(s) on which this was tested:
- MacOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nasdf nasdf

Labels
area/schema Related to the schema system feature New feature or request
Projects
None yet
Milestone
DefraDB v0.9
Development

Successfully merging a pull request may close this issue.

feat: Add blob scalar type nasdf/defradb
1 participant
@nasdf