Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite loop when updating one-one self-ref. relation field #1914

Closed
AndrewSisley opened this issue Sep 27, 2023 · 0 comments · Fixed by #1915
Closed

Infinite loop when updating one-one self-ref. relation field #1914

AndrewSisley opened this issue Sep 27, 2023 · 0 comments · Fixed by #1915
Assignees
@AndrewSisley
Labels
area/query Related to the query component bug Something isn't working
Milestone
DefraDB v0.8

Comments

@AndrewSisley
Copy link
Contributor

Depending on field names/order, updating a one-one self-referencing relationship from the secondary field can result in an infinite loop due to CollectionDescription.GetRelation
@AndrewSisley AndrewSisley added bug Something isn't working area/query Related to the query component labels Sep 27, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.8 milestone Sep 27, 2023
@AndrewSisley AndrewSisley self-assigned this Sep 27, 2023
@AndrewSisley AndrewSisley mentioned this issue Sep 27, 2023
Merged
AndrewSisley added a commit that referenced this issue Sep 27, 2023
@AndrewSisley
fix: Infinite loop when updating one-one relation (#1915)
e952be5 
## Relevant issue(s)

Resolves #1914 

## Description

Fixes an a bug where an infinite loop may be created when updating a
self-referencing one-one relation from the secondary side.
shahzadlone pushed a commit that referenced this issue Oct 2, 2023
@AndrewSisley @shahzadlone
fix: Infinite loop when updating one-one relation (#1915)
1d4f448 
## Relevant issue(s)

Resolves #1914 

## Description

Fixes an a bug where an infinite loop may be created when updating a
self-referencing one-one relation from the secondary side.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@AndrewSisley
fix: Infinite loop when updating one-one relation (sourcenetwork#1915)
d7c76df 
## Relevant issue(s)

Resolves sourcenetwork#1914 

## Description

Fixes an a bug where an infinite loop may be created when updating a
self-referencing one-one relation from the secondary side.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/query Related to the query component bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.8
Development

Successfully merging a pull request may close this issue.

fix: Infinite loop when updating one-one relation AndrewSisley/defradb
1 participant
@AndrewSisley