Remove Schema from within CollectionDescription #1913
Assignees
Labels
area/collections
Related to the collections system
refactor
This issue specific to or requires *notable* refactoring of existing codebases and components
Milestone
Comments
AndrewSisley
added
area/collections
AndrewSisley
added a commit
that referenced
this issue
Oct 24, 2023
## Relevant issue(s) Resolves #1964 #1913 ## Description Reorganises collection description storage so that it actually makes sense. The existing key/value setup has been replaced with the following keys: ``` [Collection.ID] => json // Json should be stored against an immutable index, i.e. not against `Name` [Collection.Name] => [Collection.ID] // This means collection names must be unique ``` We also need the following for the short-term, before Collection.GlobalID gets added, as otherwise if a collection is updated to a new schema version, we lose track of what collection it could be. The locations that use this have been linked to #1085 ``` [Collection.SchemaVersionId]/[Collection.ID] => nil ``` With this change the storage setup should fully support multiple collections from a single schema, however this is blocked off by `setDefaultSchemaVersion` (it doesn't allow users to explicitly specify a collection, so atm there is no way to try and do this). Later when we introduce `patchCollection` we will need to be mindful of this and block off user's ability to do this (if done before #1085).
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this issue
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#1964 sourcenetwork#1913 ## Description Reorganises collection description storage so that it actually makes sense. The existing key/value setup has been replaced with the following keys: ``` [Collection.ID] => json // Json should be stored against an immutable index, i.e. not against `Name` [Collection.Name] => [Collection.ID] // This means collection names must be unique ``` We also need the following for the short-term, before Collection.GlobalID gets added, as otherwise if a collection is updated to a new schema version, we lose track of what collection it could be. The locations that use this have been linked to sourcenetwork#1085 ``` [Collection.SchemaVersionId]/[Collection.ID] => nil ``` With this change the storage setup should fully support multiple collections from a single schema, however this is blocked off by `setDefaultSchemaVersion` (it doesn't allow users to explicitly specify a collection, so atm there is no way to try and do this). Later when we introduce `patchCollection` we will need to be mindful of this and block off user's ability to do this (if done before sourcenetwork#1085).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Replace
CollectionDescription.SchemawithCollectionDescription.SchemaVersionID.This will require changing a large number (+100) of references, PatchSchema (and tests), and the serialization/ID logic. Try and avoid changing anything else in this ticket.
Tasks
The text was updated successfully, but these errors were encountered: