Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for adding relational fields to schema #1747

Closed
Tracked by #1002
AndrewSisley opened this issue Aug 2, 2023 · 1 comment · Fixed by #1766
Closed
Tracked by #1002

Add support for adding relational fields to schema #1747

AndrewSisley opened this issue Aug 2, 2023 · 1 comment · Fixed by #1766
Assignees
@AndrewSisley
Labels
area/schema Related to the schema system feature New feature or request

Comments

@AndrewSisley
Copy link
Contributor

AndrewSisley commented Aug 2, 2023 •
edited
Loading

Part of #1002

Was deliberately blocked off in 0.6 to limit surface area, likely requires few production code changes.

See TestSchemaUpdatesAddFieldKindForeignObject
@AndrewSisley AndrewSisley added feature New feature or request area/schema Related to the schema system labels Aug 2, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.7 milestone Aug 2, 2023
@AndrewSisley AndrewSisley mentioned this issue Aug 2, 2023
Open
@AndrewSisley AndrewSisley self-assigned this Aug 2, 2023
@AndrewSisley AndrewSisley mentioned this issue Aug 8, 2023
Merged
AndrewSisley added a commit that referenced this issue Aug 9, 2023
@AndrewSisley
feat: Add support for adding of relational fields (#1766)
5034cdc 
## Relevant issue(s)

Resolves #1747

## Description

Adds support for adding of relational fields to existing schema.

It does not add any syntax magic to make this easy, but it does validate
that the provided values are valid (this is pretty much all it does).
Any magic that we add to make the UX tolerable will need to respect
these rules anyway, so no time lost there.

Similar to other aspects of the schema migration work, this also does
not seek to tidy up the `client.DescriptionFoo` objects, but it does
hope to expose and promote that cleanup in the future.

Syntax sugar and `client.DescriptionFoo` cleanup can/will be done later.
Some hopefully within this release.
@islamaliev
Copy link
Contributor

bug bash result:
ran locally a defradb node and ran commands similar to ones from integration tests

shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@AndrewSisley
feat: Add support for adding of relational fields (sourcenetwork#1766)
3b88c0a 
## Relevant issue(s)

Resolves sourcenetwork#1747

## Description

Adds support for adding of relational fields to existing schema.

It does not add any syntax magic to make this easy, but it does validate
that the provided values are valid (this is pretty much all it does).
Any magic that we add to make the UX tolerable will need to respect
these rules anyway, so no time lost there.

Similar to other aspects of the schema migration work, this also does
not seek to tidy up the `client.DescriptionFoo` objects, but it does
hope to expose and promote that cleanup in the future.

Syntax sugar and `client.DescriptionFoo` cleanup can/will be done later.
Some hopefully within this release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/schema Related to the schema system feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add support for adding of relational fields AndrewSisley/defradb
2 participants
@islamaliev @AndrewSisley