fix: Change successful schema add status to 200

[fredcarle]

Relevant issue(s)

Resolves #1100

Description

This PR changes the returned status code from the http api on a schema add call to be 200 instead of 404. It also changes a few other statuses from 400 to 500 to be more appropriate.

Tasks

• I made sure the code is well commented, particularly hard-to-understand areas.
• I made sure the repository-held documentation is changed accordingly.
• I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
• I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

manual CLI call

Specify the platform(s) on which this was tested:

• MacOS

[orpheuslummis]

LGTM. That said I thought a few of the places where it was StatusBadRequest and now StatusInternalServerError could be one of the other depending on the situation, although it seems to better to err on the side of StatusInternalServerError for perhaps a bit more clarity to the user. "The server errs with this broken request".

[codecov]

Codecov Report

Merging #1106 (fc99cb4) into develop (e2160eb) will decrease coverage by 0.02%.
The diff coverage is 85.71%.

@@             Coverage Diff             @@
##           develop    #1106      +/-   ##
===========================================
- Coverage    67.41%   67.39%   -0.02%     
===========================================
  Files          178      178              
  Lines        16635    16635              
===========================================
- Hits         11214    11211       -3     
- Misses        4474     4476       +2     
- Partials       947      948       +1     

Impacted Files	Coverage Δ
api/http/handlerfuncs.go	85.44% <85.71%> (ø)
net/server.go	59.87% <0.00%> (-0.98%)	⬇️

[source-devs]

Benchmark Results

Summary

• 0 Benchmarks successfully compared.
• 0 Benchmarks were ✅ Better.
• 0 Benchmarks were ❌ Worse .
• 0 Benchmarks were ✨ Unchanged.

✅ See Better Results...

	time/op		delta

❌ See Worse Results...

	time/op		delta

✨ See Unchanged Results...

	time/op		delta

🐋 See Full Results...

[fredcarle]

LGTM. That said I thought a few of the places where it was StatusBadRequest and now StatusInternalServerError could be one of the other depending on the situation, although it seems to better to err on the side of StatusInternalServerError for perhaps a bit more clarity to the user. "The server errs with this broken request".

Where I changed it it's because I thought a 500 error was more appropriate but if you think it's not the case in a given situation, let me know :)

[orpheuslummis]

LGTM. That said I thought a few of the places where it was StatusBadRequest and now StatusInternalServerError could be one of the other depending on the situation, although it seems to better to err on the side of StatusInternalServerError for perhaps a bit more clarity to the user. "The server errs with this broken request".

Where I changed it it's because I thought a 500 error was more appropriate but if you think it's not the case in a given situation, let me know :)

I think it's appropriate. My comment was just that there seems to be a more ideal world in which we classify perfectly between user error and server error but it'd require more work and it's not worth it at this point.