Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return proper HTTP error code on Schema add #1100

Closed
orpheuslummis opened this issue Feb 14, 2023 · 0 comments · Fixed by #1106
Closed

Return proper HTTP error code on Schema add #1100

orpheuslummis opened this issue Feb 14, 2023 · 0 comments · Fixed by #1106
Assignees
@fredcarle
Labels
area/api Related to the external API component bug Something isn't working
Milestone
DefraDB v0.5

Comments

@orpheuslummis
Copy link
Contributor

orpheuslummis commented Feb 14, 2023 •
edited
Loading

@orpheuslummis orpheuslummis added the area/api Related to the external API component label Feb 14, 2023
@orpheuslummis orpheuslummis added this to the DefraDB v0.5 milestone Feb 14, 2023
@orpheuslummis orpheuslummis added the bug Something isn't working label Feb 14, 2023
@orpheuslummis orpheuslummis mentioned this issue Feb 14, 2023
Closed
@fredcarle fredcarle mentioned this issue Feb 14, 2023
Merged
4 tasks
fredcarle added a commit that referenced this issue Feb 15, 2023
@fredcarle
fix: Change successful schema add status to 200 (#1106)
467cbe8 
Relevant issue(s)
Resolves #1100

Description
This PR changes the returned status code from the http api on a schema add call to be 200 instead of 404. It also changes a few other statuses from 400 to 500 to be more appropriate.
shahzadlone pushed a commit that referenced this issue Apr 13, 2023
@fredcarle @shahzadlone
fix: Change successful schema add status to 200 (#1106)
54512ad 
Relevant issue(s)
Resolves #1100

Description
This PR changes the returned status code from the http api on a schema add call to be 200 instead of 404. It also changes a few other statuses from 400 to 500 to be more appropriate.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@fredcarle
fix: Change successful schema add status to 200 (sourcenetwork#1106)
76e93f5 
Relevant issue(s)
Resolves sourcenetwork#1100

Description
This PR changes the returned status code from the http api on a schema add call to be 200 instead of 404. It also changes a few other statuses from 400 to 500 to be more appropriate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredcarle fredcarle

Labels
area/api Related to the external API component bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.5
Development

Successfully merging a pull request may close this issue.

fix: Change successful schema add status to 200 sourcenetwork/defradb
2 participants
@orpheuslummis @fredcarle