simplify isUpdatingIndexedFields

db/collection_index.go

@@ -199,7 +199,7 @@ func (c *collection) updateIndexedDoc(
 	for _, index := range c.indexes {
 		// We only need to update the index if one of the indexed fields
 		// on the document has been changed.
-		if isUpdatingIndexedFields(index, doc) {
+		if isUpdatingIndexedFields(index, oldDoc, doc) {
 			err = index.Update(ctx, txn, oldDoc, doc)
 			if err != nil {
 				return err
@@ -593,16 +593,13 @@ func generateIndexName(col client.Collection, fields []client.IndexedFieldDescri
 	return sb.String()
 }
 
-func isUpdatingIndexedFields(index CollectionIndex, doc *client.Document) bool {
-	for _, docField := range doc.Fields() {
-		// It is safe to discard the error here for simplicity.
-		val, _ := doc.GetValueWithField(docField)
-		if val.IsDirty() {
-			for _, indexedFields := range index.Description().Fields {
-				if indexedFields.Name == docField.Name() {
-					return true
-				}
-			}
+func isUpdatingIndexedFields(index CollectionIndex, oldDoc, newDoc *client.Document) bool {
+	for _, indexedFields := range index.Description().Fields {
+		// For simplicity, it is safe to discard the errors.
+		oldVal, _ := oldDoc.GetValue(indexedFields.Name)
+		newVal, _ := newDoc.GetValue(indexedFields.Name)
+		if oldVal.Value() != newVal.Value() {
+			return true
 		}
 	}
 	return false