update error to be more precise

sourcenetwork · Jan 25, 2025 · 82fad11 · 82fad11
1 parent 44ccc1c
commit 82fad11
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 3 deletions.
diff --git a/internal/request/graphql/schema/errors.go b/internal/request/graphql/schema/errors.go
@@ -43,7 +43,7 @@ const (
 	errDirectiveWithUnknownArg       string = "directive with unknown argument"
 	errConstraintsInvalidProp        string = "constraints directive with invalid property"
 	errEmbeddingInvalidProp          string = "embedding directive with invalid property"
-	errInvalidTypeForEmbedding       string = "embedding can only be applied to array of float32 fields"
+	errInvalidTypeForEmbedding       string = "embedding can only be applied to array of non-nillable float32 fields"
 )
 
 var (

diff --git a/tests/integration/mutation/create/embeddings/embedding_test.go b/tests/integration/mutation/create/embeddings/embedding_test.go
@@ -29,7 +29,7 @@ func TestMutationCreate_WithIntForEmbedding_ShouldError(t *testing.T) {
 						name_v: [Int!] @embedding
 					}
 				`,
-				ExpectedError: "embedding can only be applied to array of float32 fields",
+				ExpectedError: "embedding can only be applied to array of non-nillable float32 fields",
 			},
 		},
 	}
@@ -47,7 +47,43 @@ func TestMutationCreate_WithFloatForEmbedding_ShouldError(t *testing.T) {
 						name_v: [Float!] @embedding
 					}
 				`,
-				ExpectedError: "embedding can only be applied to array of float32 fields",
+				ExpectedError: "embedding can only be applied to array of non-nillable float32 fields",
+			},
+		},
+	}
+
+	testUtils.ExecuteTestCase(t, test)
+}
+
+func TestMutationCreate_WithFloat64ForEmbedding_ShouldError(t *testing.T) {
+	test := testUtils.TestCase{
+		Description: "Create mutation with invalid type for embedding",
+		Actions: []any{
+			testUtils.SchemaUpdate{
+				Schema: `
+					type Users {
+						name_v: [Float64!] @embedding
+					}
+				`,
+				ExpectedError: "embedding can only be applied to array of non-nillable float32 fields",
+			},
+		},
+	}
+
+	testUtils.ExecuteTestCase(t, test)
+}
+
+func TestMutationCreate_WithNillableFloat32ForEmbedding_ShouldError(t *testing.T) {
+	test := testUtils.TestCase{
+		Description: "Create mutation with invalid type for embedding",
+		Actions: []any{
+			testUtils.SchemaUpdate{
+				Schema: `
+					type Users {
+						name_v: [Float32] @embedding
+					}
+				`,
+				ExpectedError: "embedding can only be applied to array of non-nillable float32 fields",
 			},
 		},
 	}