-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the verbose-mode ("-v") UI the default UI for src action exec #224
Comments
Hi @mrnugget , I don't know if this is the right issue to ask for the first question but I hope it would be okay with you:
Thank you very much in advance 🙂 |
Yep. They're aliases: Lines 27 to 36 in 3b9ea70
No. Verbose should still be available — to have an effect now or in the future. The UI should simply not be dependent on the verbose flag. Off the top of my head, I think the first step would be to remove this and the whole terminal UI: https://github.com/sourcegraph/src-cli/blob/master/cmd/src/actions_exec.go#L256-L258 Then we want the https://github.com/sourcegraph/src-cli/blob/master/cmd/src/actions_exec_logger.go |
* Replace terminal UI with logger-based UI This fixes #224. * Add reference to PR to changelog
* Replace terminal UI with logger-based UI This fixes #224. * Add reference to PR to changelog
After #223 and #118 we decided that we should remove the default UI and switch to the verbose-mode UI of
src action exec
by default.The reason for that is that the currently-default UI has a big limitation we can't overcome: it only shows as many repositories as you have lines in the terminal. If you have less lines, we can't show you better progress.
The text was updated successfully, but these errors were encountered: