This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
nix: patch bazel_7 with hardcoded bin paths #59359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmudar
approved these changes
Jan 8, 2024
keegancsmith
approved these changes
Jan 10, 2024
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazel (and its community of rules) is a bit of a mess when it comes to passing around env values, including $PATH, resulting in some actions not receiving the $PATH value set via
--action_path=PATH=...that we rely on. Bazel 6 in nixpkgs had the following patch that hardcodes a set of packages to include in that case, which is currently missing from Bazel 7 in nixpkgs, so we (temporarily, hopefully) reintroduce that patch locally.See: NixOS/nixpkgs#262152 (comment) and NixOS/nixpkgs#94222 for some reading
I plan to move more bazel stuff out of shell.nix perhaps, into bazel.nix, as its a tad messy all-in-one
Test plan
bazel build //client/web/distis successful