This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
search redesign: add monaco themes for redesign #20473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umpox
reviewed
Apr 28, 2021
| const lightColors: monaco.editor.IColors = { | ||
| background: '#ffffff', | ||
| 'editor.background': '#ffffff', | ||
| 'editor.foreground': '#2b3750', |
There was a problem hiding this comment.
I think there might be some more colors we should change here, e.g. this is $gray-19 in the current design, but in the redesign that color doesn't exist and is mapped to a different value.
Can these reference CSS variables? That might be useful to map these over and keep it resilient to change
There was a problem hiding this comment.
Unfortunately these cannot be CSS variables. See microsoft/monaco-editor#2427 . Colors must be hex codes.
There was a problem hiding this comment.
As mentioned in the description, there are definitely more colors we could change here, but I decided to only fix the background for now as it's a very glaring bug.
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20280 where Monaco background color in dark mode was incorrect for the redesign.
This only changes the background color in dark mode to fix the bug, but also adds the infrastructure to customize Monaco colors later on.