This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
ci: only run go steps if only changing go #12321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should significantly speed up Go PR checks.
mrnugget
approved these changes
Jul 20, 2020
| @@ -78,12 +82,21 @@ func ComputeConfig() Config { | |||
| mustIncludeCommits[i] = strings.TrimSpace(mustIncludeCommits[i]) | |||
| } | |||
| } | |||
|
|
|||
| var changedFiles []string | |||
| if output, err := exec.Command("git", "diff", "--name-only", "origin/master...").Output(); err != nil { | |||
There was a problem hiding this comment.
What if the merge target is not master?
There was a problem hiding this comment.
I think that is fine, this will then just include more files than necessary. As an optimization if people have long lived dev branches we can make this smarter.
Note: this is the same check we have for docs changes.
pecigonzalo
added a commit
that referenced
this pull request
Sep 8, 2020
The changes from #12321 make is so we only run Go checks if required, but we need to maintain the workflow of building docker images in no-test branches
pecigonzalo
added a commit
that referenced
this pull request
Sep 8, 2020
The changes from #12321 make is so we only run Go checks if required, but we need to maintain the workflow of building docker images in no-test branches
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should significantly speed up Go PR checks.
\o/