This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Add CampaignSpecs & ChangesetSpecs tables, type definitions and campaigns.Store support #11711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrnugget
added
campaigns
batch-changes
28 tasks
eseliger
approved these changes
Jun 25, 2020
migrations/1528395685_add_campaign_specs_and_changeset_specs.up.sql
Outdated
Show resolved
Hide resolved
The schema is: - a `campaign` can have one `campaign_spec` - a `campaign_spec` can have many `changeset_spec` Most notable is that `changeset_specs.campaign_spec_id` is nullable so that users can create `ChangesetSpecs` individually and then attach them to `CampaignSpecs`. And both tables have a new `rand_id` column that contains a short, unguessable text ID that we can use as an external GraphQL node ID for both.
mrnugget
force-pushed
the
campaign-spec-api-v1-new-tables
branch
from
429c6e7 to
9b6067e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge target of this PR is https://github.com/sourcegraph/sourcegraph/pull/11675, which will contain the new campaigns workflow and allows us to merge without breaking master.
This is the next step to build up the necessary CRUD pieces and adds:
campaign_specstable, aCampaignSpectype definition and methods incampaigns.StoreChangesetSpecThe schema is:
campaigncan have onecampaign_speccampaign_speccan have manychangeset_specMost notable is that
changeset_specs.campaign_spec_idis nullable so that users can createChangesetSpecsindividually and then attach them toCampaignSpecs.And both tables have a new
rand_idcolumn that contains a short, unguessable text ID that we can use as an external GraphQL node ID for both.Other than that: this is just the usual boilerplate that we used before. Major difference is that I made the tests a bit cleaner and created separate files (!) which I think we should do for the other tables too. It's far easier to work with.