This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
docs: Fix branch prefix detection with dashes #10965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's perfectly cromulent for branch prefixes to include dashes, but the existing regex doesn't handle that possibility and generates malformed links as a result. This adds dashes to the pattern.
LawnGnome
added
the
docs-ux
ryan-blunden
approved these changes
May 25, 2020
uwedeportivo
approved these changes
May 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when admiring the draft campaign documentation in #10921 — if you go to a link that was rewritten to maintain the version prefix, such as any of the links in the sidebar screenshot below, the prefix is erroneously
@campaignsinstead of@campaigns-new-flow:There's probably an argument for this to just match anything except
/, but I've chosen to be conservative here.