address CR comments

sourcegraph · Jun 5, 2019 · 2f6a5f8 · 2f6a5f8
1 parent 5fda239
commit 2f6a5f8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/web/src/e2e/index.e2e.test.tsx b/web/src/e2e/index.e2e.test.tsx
@@ -2,7 +2,7 @@ import * as path from 'path'
 import puppeteer from 'puppeteer'
 import { saveScreenshotsUponFailuresAndClosePage } from '../../../shared/src/util/screenshotReporter'
 import { retry } from '../util/e2e-test-utils'
-import { baseURL, Driver, gitHubToken, newDriverForTest, percySnapshot } from './util'
+import { baseURL, createDriverForTest, Driver, gitHubToken, percySnapshot } from './util'
 
 // 1 minute test timeout. This must be greater than the default Puppeteer
 // command timeout of 30s in order to get the stack trace to point to the
@@ -52,7 +52,7 @@ describe('e2e test suite', function(this: any): void {
     // Start browser.
     beforeAll(
         async () => {
-            driver = await newDriverForTest()
+            driver = await createDriverForTest()
             await init()
         },
         // Cloning the repositories takes ~1 minute, so give initialization 2

diff --git a/web/src/e2e/regression.test.tsx b/web/src/e2e/regression.test.tsx
@@ -1,6 +1,6 @@
 import * as path from 'path'
 import { saveScreenshotsUponFailuresAndClosePage } from '../../../shared/src/util/screenshotReporter'
-import { baseURL, Driver, gitHubToken, newDriverForTest } from './util'
+import { baseURL, createDriverForTest, Driver, gitHubToken } from './util'
 
 // 1 minute test timeout. This must be greater than the default Puppeteer
 // command timeout of 30s in order to get the stack trace to point to the
@@ -26,7 +26,7 @@ describe('e2e test suite', function(this: any): void {
     // Start browser.
     beforeAll(
         async () => {
-            driver = await newDriverForTest()
+            driver = await createDriverForTest()
             await init()
         },
         // Cloning the repositories takes ~1 minute, so give initialization 2
@@ -156,10 +156,10 @@ describe('e2e test suite', function(this: any): void {
             5 * 1000
         )
         test(
-            'Perform global text search for "error", expect a few results.',
+            'Perform global text search for "error type:", expect a few results.',
             async () => {
                 await driver.page.goto(baseURL + '/search?q=%22error+type:%22')
-                await driver.page.waitForFunction(() => document.querySelectorAll('.e2e-search-result').length > 10)
+                await driver.page.waitForFunction(() => document.querySelectorAll('.e2e-search-result').length > 5)
             },
             5 * 1000
         )

diff --git a/web/src/e2e/util.ts b/web/src/e2e/util.ts
@@ -227,7 +227,7 @@ export class Driver {
     }
 }
 
-export async function newDriverForTest(): Promise<Driver> {
+export async function createDriverForTest(): Promise<Driver> {
     let args: string[] = []
     if (process.getuid() === 0) {
         // TODO don't run as root in CI