Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure debug-project to use jar from :semanticdb-kotlinc:shadowJar #58

Merged
merged 2 commits into from
Jul 17, 2023
Merged

configure debug-project to use jar from :semanticdb-kotlinc:shadowJar #58

merged 2 commits into from
Jul 17, 2023

Conversation

Strum355
Copy link
Contributor

Fixing debug-project configuration to more consistently depend on the semanticdb-kotlinc jar having been created

Test plan

N/A updating debug (sub)project

@Strum355 Strum355 requested review from keynmol and olafurpg July 17, 2023 15:25
@Strum355 Strum355 self-assigned this Jul 17, 2023
olafurpg
olafurpg approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea what the diff does but LGTM

@Strum355 Strum355 merged commit 582c898 into main Jul 17, 2023
@Strum355 Strum355 deleted the nsc/debug-project-ootb branch July 17, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafurpg olafurpg olafurpg approved these changes

@keynmol keynmol Awaiting requested review from keynmol

Assignees

@Strum355 Strum355

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Strum355 @olafurpg