This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Add bundle analyzer and update React imports #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katjuell
commented
Aug 11, 2021
| @@ -5,7 +5,8 @@ | |||
| "jsx-a11y/anchor-is-valid": "off", | |||
| "import/no-default-export": "off", | |||
| "react/forbid-dom-props": "warn", | |||
| "@typescript-eslint/require-await": "warn" | |||
| "@typescript-eslint/require-await": "warn", | |||
| "react/react-in-jsx-scope": "off" | |||
There was a problem hiding this comment.
My understanding is that with React v17 we can disable this.
|
✔️ Deploy Preview for sourcegraph-learn ready! 🔨 Explore the source changes: d12397b 🔍 Inspect the deploy log: https://app.netlify.com/sites/sourcegraph-learn/deploys/61146afc8b1e470007da0b7f 😎 Browse the preview: https://deploy-preview-160--sourcegraph-learn.netlify.app |
katjuell
commented
Aug 11, 2021
| @@ -61,8 +61,7 @@ const Layout: React.FunctionComponent<Props> = props => { | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | |||
| <link rel="preconnect" href="https://fonts.gstatic.com" /> | |||
| <link | |||
| rel="stylesheet preload prefetch" | |||
| as="style" | |||
| rel="stylesheet" | |||
There was a problem hiding this comment.
This will hopefully address a console warning I was seeing in prod (but not dev while working on CSS refactor): <link rel=preload> has an invalid href value. This should fix that.
katjuell
commented
Aug 11, 2021
| @@ -1,14 +1,14 @@ | |||
| import Column from '@components/atoms/Column' | |||
| import Row from '@components/atoms/Row' | |||
| import Layout, { Props as LayoutProps, MetaTags } from '@components/layouts/Layout' | |||
There was a problem hiding this comment.
Taking MetaTags out here, since this is unused.
ltagliaferri
approved these changes
Aug 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What should this PR do?
This PR resolves DEVED-106 by adding a bundle analyzer to our project and updating some of our import statements.
You can now run
npm run analyzeto look at the current state of the app. It will be helpful to also use tools like https://bundlephobia.com/ before adding any new packages to the app.This PR also updates our React imports to work with current thinking, avoiding redundant imports. See also this PR
Why are we making this change?
We want our user experience to remain optimal.
What are the acceptance criteria?
How should this PR be tested?
node_modules, and install dependencies withnpm ci.npm run analyzeand ensure that analyzer works.Pull request process
Reviewers:
Reviewees: