update tools go.mod and fix package import #4288
Merged
+2,413
−2,718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strum355
reviewed
Jan 4, 2024
|
|
||
| go 1.16 | ||
| go 1.21.5 |
There was a problem hiding this comment.
Does this need bumping too? https://github.com/sourcegraph/deploy-sourcegraph/blob/master/.github/workflows/update-tags.yml#L17
There was a problem hiding this comment.
Ah good catch. Might as well update it!
Strum355
approved these changes
Jan 8, 2024
jhchabran
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
check-image-names.shwas failing due to a package import change. In the process of updating the import I also updated the go.mod to be 1.21.buildkite/prettier-check.shby moving package.json to the root of the repo. With it being in root of the repo it won't install the integration test dependencies to run prettier.Test plan
Executed locally and CI