Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove current repo link to docs for enterprise users #7118

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AJKemps
Copy link

@AJKemps AJKemps commented Feb 18, 2025

linear

Test plan

Current state causing confusion. When an Ent user has a project open locally that isn't available remotely, they get this "not yet available" CTA that links out to a docs page about code host configuration, which is causing lots of questions to customer admins that are unnecessary

Screenshot 2025-02-17 at 3 37 51 PM

After changes for Ent User with a local project that is available remotely
Screenshot 2025-02-17 at 9 27 28 PM

After changes for Ent User with a local project that is not available remotely
Screenshot 2025-02-17 at 9 28 15 PM

@AJKemps AJKemps marked this pull request as ready for review February 18, 2025 02:43
Copy link
Contributor

@dominiccooney dominiccooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added because there was a concern that Teams users need a call to action to index repositories, so I would either:

  • Decide we don't want the CTA at all, and revert the change that added it. Or,
  • Decide we do want the CTA for Teams, but not Enterprise. In that case you should not use isEnterpriseUser but instead something which calls isWorkspaceInstance(authStatus.endpoint). Or,
  • Decide that we want the callout for both but improve the docs.

As-is this change isn't good because we're carrying around the code for this CTA which is never shown.

@kalanchan
Copy link
Contributor

kalanchan commented Feb 18, 2025

Decide that we want the callout for both but improve the docs.

My vote is for this, without the CTA users get confused on why they don't have indexing. I'll follow up with updating a page about indexing itself and what it means to have repo context.

I don't think we should be removing the ability to @ mention the current repo, as this also affects enterprise starter customers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants