allow subscribing to OpenCtx controller before it's initialized #6931
+147
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqs
force-pushed
the
sqs/init-openctx-ctrl
branch
from
7cc0d61 to
d1e47d3
Compare
3 tasks
Previously, if some statically initialized value tried to read the `openCtx.controller` before it was set in `exposeOpenCtxClient`, it would throw. This required some contortions to ensure that it was initialized only after `exposeOpenCtxClient` was called. Now, anything can subscribe to `openctxController` at any time, and it will receive an emission of the OpenCtx controller when it's ready.
sqs
force-pushed
the
sqs/init-openctx-ctrl
branch
from
d1e47d3 to
298c29c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if some statically initialized value tried to read the
openCtx.controllerbefore it was set inexposeOpenCtxClient, it would throw. This required some contortions to ensure that it was initialized only afterexposeOpenCtxClientwas called. Now, anything can subscribe toopenctxControllerat any time, and it will receive an emission of the OpenCtx controller when it's ready.Test plan
CI