[Backport jb-v7.12.x] omnibox: open results locally if possible #6800
+81
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the behavior of clicking search results to link to local files if the result represents a file in your local repo. With the [recent changes](sourcegraph/sourcegraph#2943) that heavily prefer results from your current repo, this should now be most results. (cherry picked from commit 7ed51f2)
ErikaRS
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport request details: this is a low-risk, high-impact UX change that significantly improves the usefulness of omnibox search results by linking the local version of a file instead of a read-only view of the file from Sourcegraph.
This modifies the behavior of clicking search results to link to local files if the result represents a file in your local repo. With the recent changes that heavily prefer results from your current repo, this should now be most results.
Test plan
Video walkthrough
Backport 7ed51f2 from #6781