Fix intent telemetry (#6779) #6795
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression in the intent telemetry (described [here](https://linear.app/sourcegraph/issue/SPLF-330), originally fixed in #6637). Two fixes: - we weren't using the right fields in `commonProps`, meaning that the values weren't assigned to the message and thus weren't accessible in the chat controller where we emit metadata. - we were accidentally overriding the `userSpecifiedIntent` field with `auto` because of operator precedence. We now get the correct data emitted in the `chat/executed` telemetry events. I want to backport this to vscode-1.64 and jb-7.12. Why? Telemetry data will help us improve intent detection significantly and it's important we have the pipeline functioning well at launch. Furthermore, the changes are quite low-risk. Tested manually. (cherry picked from commit 1049a20)
ErikaRS
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression in the intent telemetry (described here, originally fixed in #6637). Two fixes:
commonProps, meaning that the values weren't assigned to the message and thus weren't accessible in the chat controller where we emit metadata.userSpecifiedIntentfield withautobecause of operator precedence.We now get the correct data emitted in the
chat/executedtelemetry events.I want to backport this to vscode-1.64 and jb-7.12. Why? Telemetry data will help us improve intent detection significantly and it's important we have the pipeline functioning well at launch. Furthermore, the changes are quite low-risk.
Test plan
Tested manually.
(cherry picked from commit 1049a20)